search

image-rs / imageproc

Image processing operations
MIT License
735 stars 145 forks source link

Update MSRV and replace "minimal-versions" check with "direct-minimal-versions" test #555

Closed cospectrum closed 6 months ago

cospectrum commented 6 months ago

-Zminimal-versions + cargo check will validate only default features without dev-dependencies. But -Zminimal-versions + cargo +nightly test --all-targets --all-features is completely broken due to indirect dependencies. We can try to update with -Zdirect-minimal-versions instead and then test.

MSRV updated from 1.63 to 1.65 for property-testing feature. Added --all-features to the msrv workflow (note: additional --all-targets flag will not work due to nightly tests).

cospectrum commented 6 months ago

I'm actually not sure if we should increase MSRV to 1.65. But this way we will support one MSRV for all-features

CommanderStorm commented 6 months ago

not sure if we should update MSRV to 1.65

Given that image-rs has a MSRV of 1.67.1 and that they are likely used together I don't think this should be a roadblock, or is there something I am missing/misunderstanding?

cospectrum commented 6 months ago

not sure if we should update MSRV to 1.65

Given that image-rs has a MSRV of 1.67.1 and that they are likely used together I don't think this should be a roadblock, or is there something I am missing/misunderstanding?

True, updating to the new image = "0.25" requires 1.67.1 rustc. We are currently dependent on "0.24.7", but it's probably a good idea to keep up

fintelia commented 6 months ago

For what it's worth, the release of image 0.25 and the associated MSRV bump happened literally yesterday :smile: