Closed ripytide closed 3 months ago
This broadly looks good to me.
The two main changes I'd like are:
Kernel::filter
, and optionally mark them as deprecated - I'm a bit wary of causing user churn for the sake of a few one-line functions.I've implemented the requested changes, are the deprecation warnings ok?
Looks good to me, thanks!
Just needs the version updating to 0.26 in Cargo.toml to get the semver check to pass.
Third time lucky! Thanks - I think exposing filter
and filter_clamped
this way is a definite improvement.
I think I made a mistake in #601 by changing too much at once. This time I've focused on some of the core changes and discarded some others (such as no kernel trait this time).
Summary:
filter()
method to free-standingfilter()
functionfilter_clamped()
function which was whatfilter3x3()
was doing previouslyfilter3x3()
sincefilter_clamped()
is identical and works with any dimensionskernel
module as associated constants ofKernel
rather than free-standing constantssobel_vertical()
and similar functions as they are simply applications offilter_clamped()
with different kernels which is not very maintainable as the number of different kernels grows.FOUR_LAPLACIAN_3X3
andEIGHT_LAPLACIAN_3X3
kernel constants.