image-rs / imageproc

Image processing operations
MIT License
736 stars 144 forks source link

Gradient Refactor V3 #611

Closed ripytide closed 3 months ago

ripytide commented 3 months ago

I think I made a mistake in #601 by changing too much at once. This time I've focused on some of the core changes and discarded some others (such as no kernel trait this time).

Summary:

theotherphil commented 3 months ago

This broadly looks good to me.

The two main changes I'd like are:

ripytide commented 3 months ago

I've implemented the requested changes, are the deprecation warnings ok?

theotherphil commented 3 months ago

Looks good to me, thanks!

Just needs the version updating to 0.26 in Cargo.toml to get the semver check to pass.

theotherphil commented 3 months ago

Third time lucky! Thanks - I think exposing filter and filter_clamped this way is a definite improvement.