search

imagemin / meta

General discussion repo for imagemin related projects
6 stars 2 forks source link

Test on AppVeyor #5

Closed shinnn closed 9 years ago

shinnn commented 10 years ago

http://www.appveyor.com/

We should check if imagemin and its plugins work well on Windows, like Grunt projects.

sindresorhus commented 10 years ago

:+1: Example: https://github.com/gruntjs/grunt/blob/master/appveyor.yml

shinnn commented 10 years ago

First I introduced AppVeyor to imagemin-jpeg-recompress. It works correctly.

https://github.com/imagemin/imagemin-jpeg-recompress#imagemin-jpeg-recompress--

kevva commented 10 years ago

We should switch that Travis badge to be flat so they look nicer together.

shinnn commented 10 years ago

Like this?

 Build status

sindresorhus commented 10 years ago

Yup

kevva commented 10 years ago

shields have a badge for Appveyor too.

shinnn commented 10 years ago

I'd rather use original AppVeyor badge. It's difficult to see which badge represents the result of AppVeyor.

kevva commented 10 years ago

True.

kevva commented 10 years ago

@shinnn, can we remove AppVeyor from the repos? It's slow, mostly fails and doesn't show any good output. We can use it on the main imagemin repo (and maybe the plugins) when/if we can use a newer npm version.

shinnn commented 10 years ago

@kevva

We can fix a lot more error on Windows with more cross-platform code, like this commit. I still want to continue testing on AppVeyor.

However, as you know, it's very hard to rebuild binaries on AppVeyor. They fails without any outputs and we can't find the causes. So, How about skipping rebuilding tests on AppVeyor by using is-appveyor?

shinnn commented 10 years ago

I created a fork which skips the 'rebuild the cwebp binaries' test on AppVeyor.

It passes the test.

sindresorhus commented 10 years ago

I'm fine with us continuing using AppVeyor as long as I don't have to care about it.

kevva commented 10 years ago

I don't care if it fails and shows good error output. But currently it just shows that it failed but not why. AppVeyor is so bad imo. The commit you're referring to is a conscious decision by me (to use &&). If we are writing stupid workarounds for Windows we're doing it wrong. I rather let the tests fail on Windows.

shinnn commented 10 years ago

I agree with you that we shouldn't write stupid workarounds.

OK, now I'd like to propose:

What do you think?

sindresorhus commented 10 years ago

Create and remove directories programmatically after ava supports before and after. (imagemin/jpeg-recompress-bin@481046c#commitcomment-8256698) Do you have any plans for them, @sindresorhus?

Yes, it's top pri for ava, but probably won't happen for a while, as I'll be traveling.

kevva commented 10 years ago

@shinnn, yup, sounds good to me. Build scripts won't work on Windows 90% of the time anyway.

@sindresorhus, I could write a fast temporary patch that implements it if you want to.