imageworks / OpenColorIO-Configs

Color Configurations for OpenColorIO
opencolorio.org
440 stars 801 forks source link

About culling down ACES versions. #13

Open KelSolaar opened 6 years ago

KelSolaar commented 6 years ago

I would be keen on discussing about potentially removing the various ACES config versions in the ImageWorks repository and keep a single one that would maybe be a git-submodule hosted on an AMPAS dedicated repository.

@aforsythe, @scoopxyz, @lgritz (and anybody interested) any thoughts?

scoopxyz commented 6 years ago

I'm all for getting just the current ACES config in the master repo.

I would like to maintain the older versions by keeping a separate branch called "legacy". This should substantially decrease the repo size and make it quite clear to users what they should grab.

KelSolaar commented 6 years ago

This should substantially decrease the repo size and make it quite clear to users what they should grab.

I could be wrong but without re-writing history I'm not sure the gains will be significant as you will still have the files in a blob within git tree.

scoopxyz commented 6 years ago

In my quick tests I'm seeing a download size reduction from 877.1 MB to 347 MB

lgritz commented 6 years ago

Download of the zip will decrease, but the repo size (what you get if you git clone) will not. Even a local git repo has the full history of the project.

lgritz commented 6 years ago

I'm all for removing the old ACES configs, and for that matter, even putting the extant ones in git LFS rather than in the main repo.

dekekincaid commented 6 years ago

While you are at it there still isn’t even a tagged released for aces 1.0.0-1.0.3 on either the Sony or the AMPAS repo. The last one was a 1.0_r2. We still grab it from HP’s repo because he has all versions properly tagged and released there. It would be good to have these properly setup.

On Fri, Feb 16, 2018 at 19:52 Thomas Mansencal notifications@github.com wrote:

I would be keen on discussing about potentially removing the various ACES config versions in the ImageWorks repository and keep a single one that would maybe be a git-submodule hosted on an AMPAS dedicated repository.

@aforsythe https://github.com/aforsythe, @scoopxyz https://github.com/scoopxyz, any thoughts?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/imageworks/OpenColorIO-Configs/issues/13, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHaAUAyrA2mMHEIw3yySpiYGECQExpyks5tVkz7gaJpZM4SJLYF .

KelSolaar commented 6 years ago

Download of the zip will decrease, but the repo size (what you get if you git clone) will not.

Yeah sorry, I was referring to repo size.

It would be good to have these properly setup.

Yes absolutely!

scoopxyz commented 6 years ago

Download of the zip will decrease, but the repo size (what you get if you git clone) will not

Yes, of course, but there are about 4-5 people doing development work on the repo, the majority use case is just downloading the files to use. I'll need to read a bit more about LFS to see how it integrates into things.

there still isn’t even a tagged released for aces

Yes, there was a sidebar conversation that prompted this ticket. Just needs to be done.

KelSolaar commented 6 years ago

As highlighted in this comment, it should be possible to trim some fat by reducing indentation of the spi1d LUTs, some have 8 or 9 characters which is simply overkill.

Cheers,

Thomas