imaginary-cloud / CameraManager

Simple Swift class to provide all the configurations you need to create custom camera view in your app
MIT License
1.37k stars 320 forks source link

Added missing callback when recording stops and the user don't give a… #243

Open rpgzibralabs opened 3 years ago

rpgzibralabs commented 3 years ago

It is missing a callback after the recording stops and the user don't give permissions to save the video to the Photo Library.

As the code is right now the callback is not performed when the user chooses not to give permissions for saving the video into the Photo Library. The callback is only called when the user gives permission and there's not callback to perform an action afterwards. It could be a good idea to maybe return an error when the writeFilesToPhoneLibrary flag is true and the user don't allows access to the Photo Library.

NikKovIos commented 1 year ago

Leaks could be, I think