search

imbo / behat-api-extension

API extension for Behat, used to ease testing of JSON-based APIs
MIT License
109 stars 42 forks source link

change base_uri validation #64

Closed oxkhar closed 6 years ago

oxkhar commented 6 years ago

Validation of 'base_uri' in config definition makes throw error when behat is executed without API server has been launched.

Problem is when run behat for other reason that not was to test features, with "--help" for example, always stop with connection error.

Fixed changing validation location in api context initializer that throw error only when we run test features, in other way behat runs ok.

christeredvartsen commented 6 years ago

@oxkhar FYI: I just rebased your branch on develop as another PR was merged.

christeredvartsen commented 6 years ago

~I'm guessing this PR is no longer needed if we choose to go for the change that will be introduced in #67. I will keep it open until #67 is closed.~

christeredvartsen commented 6 years ago

@vitalyiegorov Do you have anything to add with regards to the changes introduced in this PR? It basically makes the validation of the connetability of base_uri kick in at a later stage.

vitalyiegorov commented 6 years ago

Agree @christeredvartsen I think it makes sense