search

imgix / gatsby

A simple yet powerful integration between Gatsby and imgix
BSD 2-Clause "Simplified" License
30 stars 6 forks source link

fix: no support for `gatsby-plugin-image@3` so no `gatsby@5` support #266

Closed arsinclair closed 1 year ago

arsinclair commented 1 year ago

With the recently introduced GatsbyJS v5 support the gatsby-plugin-image dependency hasn't been updated. This is relevant section of package.json:

  "peerDependencies": {
    "gatsby": "^2 || ^3 || ^4 || ^5",
    "gatsby-image": "^2 || ^3",
    "gatsby-plugin-image": "^1 || ^2"
  },

This invalidates GatsbyJS v5 support, because v5 requires gatsby-plugin-image to be v3.

luqven commented 1 year ago

Hey, @arsinclair, thanks for opening this issue.

Yup looks like we forgot to change gatsby-plugin-image dep to "gatsby-plugin-image": "^1 || ^2 || ^3". My apols; our CI is in the middle of being fixed and would/should have caught this.

I'm just taking a look at this now. I'll update this issue once we've had a chance to address this.

luqven commented 1 year ago

Quick follow-up @arsinclair,

While we address this, can you try to install using the --legacy-per-deps flag for NPM? This tells NPM to ignore old dependencies for this package.

I've tested this myself and haven't run into any issues. I hope this will unblock you quickly. If not, we are still cutting @next release with this issue resolved soon.

arsinclair commented 1 year ago

Thanks for quick response. Yes, --legacy-per-deps works locally, but in order for the site to be deployed, I'll have to update our CI scripts to also use --legacy-per-deps and there's no value in doing so because then I'll have to roll it back.

I'll wait for the next release, hopefully it shouldn't take much time :)

luqven commented 1 year ago

Thanks for the quick response, @arsinclair; that makes sense.

I've cut a next release now from #267. I think this should address your issue. If you can pull down @imgix/gatsby@next and confirm that the issue is resolved, that'd be great.

Either way, we'll cut a release to @latest soon.

arsinclair commented 1 year ago

Thanks @luqven, just tested on the next release and it works!

imgix-git-robot commented 1 year ago

:tada: This issue has been resolved in version 2.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: