negative value for gamepad id

ylafon commented 4 years ago

While looking at https://github.com/w3ctag/design-reviews/issues/430 during our F2F, we figure out that section 3.2 is mandating gamepad's index to be -1. Gamepad Index definition states that it is a positive integer, so an issue must be files on Gamepad to document the delegation of identification of the gamepad when the index is negative (or with a specific value of -1). You might also want to defined a specific value to achieve the same for the gamepad id.

ylafon commented 4 years ago

Just to reiterate, as negative values are in direct contradiction with the Gamepad spec, please work with them to figure out a way forward (allowing negative values with a "reserved" definition, register specific positive values for that or anything that would solve this conflict). Thanks!

Manishearth commented 2 years ago

https://github.com/immersive-web/webxr-gamepads-module/issues/27

himorin commented 6 months ago

@toji @cabanier we have an answer from gamepads spec's editors as https://github.com/w3c/gamepad/pull/158#issuecomment-1888207277 is it possible to consider of fix within gamepads module of WebXR?

/cc @Manishearth

Manishearth commented 6 months ago

It seems like Gamepad told us to continue doing whatever we're doing so I'm not sure if there's anything more to be done here.

We can potentially say we are modifying that spec? Not sure if that's a good path.

himorin commented 16 hours ago

@Manishearth sorry for quite late catch.

Summary as below, please correct if something wrong

change made to Gamepads spec (w3c/gamepads#151) and new selecting an unused gamepad index algorithm was introduced (diff)
now, there is no positive integer restriction in gamepad index, although selecting an unused gamepad index algorithm will return non-negative integer (0 or positive) values and navigator.getGamepads() returns as array whose index starts from 0
WebXR gamepads module does not take array of gamepads, just has single readonly attribute Gamepad XRInputSource.gamepad not array as Gamepad specification. Also, index -1 will be assigned if target device is not exposed via navigator.getGamepads(). No conflict or handling issue in this space, also device with index -1 is specific within WebXR space which will not conflict (by means of shared or reused) with any other specifications relying on Gamepad specification.

@ylafon does above solve concern from design review point of view?

immersive-web / webxr-gamepads-module

negative value for gamepad id #27