impact / search

A web application to search the impact index
MIT License
12 stars 5 forks source link

Add support for emoji icons #10

Open tbeu opened 9 years ago

tbeu commented 9 years ago

Search for "xml" in the search field. The only hit contains an emoji Icon in its description which is displayed as text.

xogeny commented 9 years ago

This is because the person who added the description for that library chose to include GitHub specific emoji markup in the description. I'm rendering exactly the description the library author included.

An argument could be made that it would be nice if the emoji images were embedded in the impact search results. I would accept a pull request for this. But I couldn't find an existing package that takes HTML with emoji markup and returns HTML with emoji images embedded and I don't want to implement that functionality right now.

tbeu commented 9 years ago

Isn't it here https://github.com/node-modules/emoji?

xogeny commented 9 years ago

Perhaps. I'll investigate.

xogeny commented 9 years ago

No. The one you referenced converts unicode characters into the associated image.

The module required in this case must transform a string that uses markup into HTML. This one handles that.

xogeny commented 9 years ago

BTW, this is a very nice reference for the various markup patterns:

http://www.emoji-cheat-sheet.com/

xogeny commented 9 years ago

It should be noted that emojify seems to be the standard. But it also includes a very large CSS file. An alternative approach, used here, is to include a bunch of static images. This means less downloading up front.

I don't really want to host all those static images within the GitHub page. I think it is "neater" to just have the CSS fine. So I'm more inclined to go with emojify. But this is pretty low on my list of priorities.

tbeu commented 9 years ago

BTW, this is a very nice reference for the various markup patterns: http://www.emoji-cheat-sheet.com/

Guess what I use all the time? :smirk:

dietmarw commented 9 years ago

@tbeu Until this is resolved you might consider removing the emoji from your description.

tbeu commented 9 years ago

But they are really nice eye-catchers in the GitHub description. :jack_o_lantern:

tbeu commented 8 years ago

HNY! :fireworks:

tbeu commented 7 years ago

:new: January :snowman: