imperialCHEPI / healthgps

Global Health Policy Simulation model (Health-GPS)
https://imperialchepi.github.io/healthgps/
BSD 3-Clause "New" or "Revised" License
5 stars 1 forks source link

[UMBRELLA] Generalise form 'static' and 'dynamic' risk factor models #231

Open jamesturner246 opened 8 months ago

jamesturner246 commented 8 months ago

For context, in existing HealthGPS speak, static means initialise and dynamic means update.

The concept of the 'static' and the 'dynamic' risk factor models is already a little cloudy.

Some Dynamic models also do initialisation, and vice versa. Both model types have generate_ and update_risk_factors methods. So why not relax the restriction of having static and dynamic models, and just use the generate and update methods of both where appropriate?

This would also allow us to create as many risk factor models as we like, and stop polluting our models with hacky 'extras' where needed.

Also perhaps some way of grouping these modules, akin to the current separation of risk factor, demographic, analysis classes.

Tasks

dalonsoa commented 8 months ago

Is this related to #194?

jamesturner246 commented 7 months ago

Related, but opposite ideas. @israel-vieira was rightfully against this change because modularity of model components would decrease with such a change -- i.e. models would become more bloated. This change seeks to reverse that by having separate modules for each unit computation -- i.e. the opposite of what #194 proposes. I will close #194, to avoid confusion.