Open jamesturner246 opened 8 months ago
Is this related to #194?
Related, but opposite ideas. @israel-vieira was rightfully against this change because modularity of model components would decrease with such a change -- i.e. models would become more bloated. This change seeks to reverse that by having separate modules for each unit computation -- i.e. the opposite of what #194 proposes. I will close #194, to avoid confusion.
For context, in existing HealthGPS speak, static means initialise and dynamic means update.
The concept of the 'static' and the 'dynamic' risk factor models is already a little cloudy.
Some Dynamic models also do initialisation, and vice versa. Both model types have
generate_
andupdate_risk_factors
methods. So why not relax the restriction of having static and dynamic models, and just use thegenerate
andupdate
methods of both where appropriate?This would also allow us to create as many risk factor models as we like, and stop polluting our models with hacky 'extras' where needed.
Also perhaps some way of grouping these modules, akin to the current separation of risk factor, demographic, analysis classes.
Tasks