search

imperodesign / generator-impero

Impero's website skeleton generator, courtesy of Yeoman
Other
1 stars 1 forks source link

Replace eslint custom rules with standard.js #28

Closed pvalentim closed 8 years ago

pvalentim commented 8 years ago

http://standardjs.com/

Any reason this wouldn't work with our setup ?

samhh commented 8 years ago

Seems like it would be okay. React support built-in, TypeScript support via standardts. I'll give it a go!

samhh commented 8 years ago

I think it may make more sense to use this: https://github.com/feross/eslint-config-standard

That way we're sticking with ESLint and can swap configs more easily in the future should we desire, plus altering it at all would be easier. Besides, we'd need the Babel ESLint parser for Standard anyway.

samhh commented 8 years ago

Immediate benefit: Right now by default the standard config forces single quotes in React JSX. Almost all convention says that React should use double quotes a la HTML/XML etc. This is easily overridden with the above. 👍

samhh commented 8 years ago

https://github.com/imperodesign/generator-impero/commit/1b065cf29a1f9b5e83f108e08e617a6a1cb2c8df

Also in alpha10.