Fix primitive extension handling

improbable-eng / ts-protoc-gen

Protocol Buffers Compiler (protoc) plugin for TypeScript and gRPC-Web.

Apache License 2.0

1.36k stars 173 forks source link

Fix primitive extension handling #276

Closed MarcusLongmuir closed 3 years ago

MarcusLongmuir commented 3 years ago

Changes

Getter check prevented null being acceptable for the type name which is the case for primitives
Fixes #273

Verification

Added tests for extensions

improbable-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: moadz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/improbable-eng/ts-protoc-gen/blob/master/OWNERS)~~ [moadz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment