imr-framework / pypulseq

Pulseq in Python
https://pypulseq.readthedocs.io
GNU Affero General Public License v3.0
111 stars 58 forks source link

Fixed `read_seq` for reading v1.3.1 sequence files #162

Closed FrankZijlstra closed 5 months ago

FrankZijlstra commented 6 months ago

Should fix #161

FrankZijlstra commented 5 months ago

In general, the types in event_lib are not all correct and the employed update() method doesn't require old data, which you just consequently set to None here , but this is something we can discuss during the code refactoring process and not here I guess.

When I removed the use of old_data before, I did consider just removing it altogether, but figured that it would be a good idea to keep compatibility (in the unlikely case someone was ever adventurous enough to mess with the event libraries...). But I think it's pretty safe to remove altogether.