search

imsky / holder

:city_sunrise: Client-side image placeholders.
http://holderjs.com
MIT License
5.84k stars 592 forks source link

Shaven 0.8.1 not capable with node^6 #209

Closed Haocen closed 7 years ago

Haocen commented 7 years ago

Unsupported engine for shaven@0.8.1: wanted: {"node":"~0.12.2"} (current: {"node":"6.10.3","npm":"3.10.10"})

imsky commented 7 years ago

@Haocen what was the reason for closing the PR? issue resolved?

Haocen commented 7 years ago

For whatever reason shaven@1.1.0 still want node~0.12 which will cause holders fail to install on any morden node environment.

Luckily this only affect user who has engineStrict set to 'true' in their project or npm globally.

Unfortunately I have to enforce engineStrict in my project, but I find a walk around by move shaven into dev dependencies since I I need is dist version of holders. I haven't run into any problems so for.

imsky commented 7 years ago

thanks for the explanation, that makes sense