search

in2code-de / luxletter

Newsletter system for TYPO3
https://www.in2code.de/agentur/typo3-extensions/luxletter/
22 stars 25 forks source link

Make Luxletter news templating compatible with tx_news v11 #204

Closed agendartobias closed 7 months ago

agendartobias commented 7 months ago

This fixes the error:

tt_content.CType=news_pi1 is not yet supported in FluidStyledMailContent (Part of EXT:luxletter)

when you use extension news 11.x.x

einpraegsam commented 7 months ago

Thx for digging into it. Even if this can work, I think there should be a better way. What if you simply add a new template file with name NewsPi1.html in folder EXT:luxletter/Resources/Private/FluidStyledMailContent/Templates/. I think that should do the trick. In addition we should cleanup the existing List.html template by removing the if-condition.

agendartobias commented 7 months ago

Hey,

but typoscript definition: tt_content.news_pi1.templateName = NewsPi1 must exist. If not the template Generic.html is called (default settings of fluid_styled_content).

So are you ok with this typoscript definition? Then i can remove /luxletter/Resources/Private/FluidStyledMailContent/Templates/List.html and /luxletter/Resources/Private/FluidStyledMailContent/Templates/News/List.html and just create NewsPi1.html as you recomended.

einpraegsam commented 7 months ago

Hi, I just digged into the issue and made a commit based on your pull request. I thought I make the changes by my own to minify unneeded time. Hope that's ok for you. See: https://github.com/in2code-de/luxletter/commit/9ecde16c726d8622ae36fdf95f74cec92dbe422b Thx for your time!