in2code-de / luxletter

Newsletter system for TYPO3
https://www.in2code.de/agentur/typo3-extensions/luxletter/
22 stars 25 forks source link

Javascript in mail markup t3sbootstrap #206

Closed PittRo closed 7 months ago

PittRo commented 7 months ago

Typo3: 11.5.34 Extension: luxletter - TYPO3 Email Marketing Newsletter Tool luxletter 19.2.2 Extension: Bootstrap Components t3sbootstrap v5.2.8 Sample NL: https://wir.gorheinland.com/gonewsletter-ausgabe-januar-2024/ Usecase: E-Mail posting

responsible script: typo3conf/ext/t3sbootstrap/Classes/EventListener/AssetRenderer/IsInline.php included javascript:

We use with t3s within our typo3 instance, if we sen emails via luxletter, fluid pharses inline CSS. therefor t3sbootstrap renders a <script... into html markup. May you help us with any option we could easyly set?

We were already looking for any option like this at /typo3/module/web/T3sbootstrapM1?id=1&tx_t3sbootstrap_web_t3sbootstrapm1%5Bconfig%5D=1&tx_t3sbootstrap_web_t3sbootstrapm1%5Baction%5D=edit&tx_t3sbootstrap_web_t3sbootstrapm1%5Bcontroller%5D=Config

einpraegsam commented 7 months ago

This seems to be not a task for LUXletter? You should configure t3sbootstrap in a way that the JS is not included when calling a page with type 1562349004 in my eyes. Or do I missunderstood your question?

PittRo commented 7 months ago

There is no possibiltiy to configure that. I guess your extension is definitely responsible for the parsed markup and even should validate it. I opened up a connector issue in there repo.

einpraegsam commented 7 months ago

Okay, but if there is an extension that adds JS - no matter what TypeNum - this seems to be a general problem. Don't you think? What if you want to build an AJAX request with a special TypeNum or a print view or whatever...

einpraegsam commented 7 months ago

I will close this issue for now. Pls reopen if it turns out, that the problem is related to LUXletter.