Stop using GeneralUtility::makeInstance everywhere

[georgringer]

Please stop using GeneralUtility::makeInstance() everywhere! It is only needed if

• XCLASS is allowed
• If class was not injected and injection should be used

Please don't use for stuff like creating basic objections, especially not:

• Objects for events which are final anyway!
• Models, like GeneralUtility::makeInstance(User::class);

[einpraegsam]

Thx for your hints. Any real problems or simply a small rant?

[einpraegsam]

I guess not. I will consider using more DI even if this is often a pain. Nevertheless, there is nothing to do for the moment. It is more a general task.

[georgringer]

it is not a rant, but saw it because phpstorm told me about some warnings

and it is smaller to read

        $event = $this->eventDispatcher->dispatch(
            new NewsletterParseSubjectEvent($subject, $properties)
        );