Open Charlotte-Morgan opened 7 years ago
Hi @Charlotte-Morgan can you clarify the meaning of the 'on' prefix in your examples above?
+1 To have names of datasets with meaningful names.
Oh - that looks silly. I think it was supposed to say something like:
<hazard>on<exposure>_map_A4.pdf
<hazard>on<exposure>_report.pdf
Happy for your team to work out what is possible now
Ah maybe you put angle brackets in the names above. Editing your comment above to put the example in back ticks might fix it.
:) done
👍
I guess one hitch with this while I am thinking about is is we will need to add another layer of logic in the metadata to keep track of what the output layers are and what their significance is. I wonder if it would not be better to give the output folder a meaningful name, the layer titles meaningful names but the actual on-disk file names adhering to a standard naming so that we can point to an analysis directory without knowing anything about it and find e.g. analysis_layer
I'll put some more thought on this:
Ok that sounds good thanks @lucernae
on _map_A4.pdf on _report.pdf Happy for your team to work out what is possible now
Hi @Charlotte-Morgan I agree for this. But, to make it unique, I proposed to add date and time as an ID for the result.
<date><time>_<hazard>on<exposure>_map_A4.pdf
<date><time>_<hazard>on<exposure>_report.pdf
One confusion that may come from adding date/time to the file name is that we need to make it clear it is not the event time, but the analysis time.
@lucernae any feedback on this? Maybe we can assign to @myarjunar
One confusion that may come from adding date/time to the file name is that we need to make it clear it is not the event time, but the analysis time.
What's the feedback on this @samnawi ?
Was
@lucernae I think just make a call on this and go with @samnawi 's last suggestion:
<date><time>_<hazard>on<exposure>_report.pdf
I'm stuck on this. So the problem is, I need the impact function to be serializable so I can get impact_function's provenance and resolve the file name even if the user change layers. Perhaps we can move it to 4.1?
@lucernae we are going to hand this over to @myarjunar to implement. Just rename the generated reports according to the naming convention above. For now the generated GIS datasets should keep their current names.
I had some work in progress that I can handover. We need to make impact function serializable, that's the blocker.
The PDF renaming is going to have a lot of side effects - I am holding this over to 4.3 as we won't be able to resolve it in time for 4.2
From the desktop side I think this is easier to manage now because the PDF's are generated on the fly at print time. We need to figure out in realtime how to pass back something which says what the name of the generated PDF is so that the web UI can predictably find the output.
Problem
InaSAFE 4.0 generates a folder for impact analyses (yay) but the files in the outputs folder do not have unique names. These files (map and reports) are the files most likely to be shared but they only have names based on templates
Expected Behaviour
File names for maps and reports should be more explicit in their file naming, preferably unique.
Proposed Solution
make the file names something like this for now
In the future - aim to make them more like a realtime event file name