search

inblockio / aqua-verifier-webextension

A Chrome-Browser web-extension to verify Aqua Protocol data.
https://inblock.io
MIT License
6 stars 2 forks source link

Apply name-resolution also to verification output #60

Closed FantasticoFox closed 2 years ago

FantasticoFox commented 2 years ago

There is a quite critical issue for us, that the name-resolution which works on the page with the content_script is not applied to the print out of the verification data.

The user expects to have a consistent name resolution and will be shocked to see a 'naked' wallet address ;)

FantasticoFox commented 2 years ago

Example where name resolution should be applied: image

In the header of the page: image

Example of nameresolution: This is applied in pages like this https://playground.inblock.io/index.php/0xa2026582b94feb9124231fbf7b052c39218954c2:ANS image

If you copy the names and wallet addresses into your ANS then it will allow you to resolve all those wallets in the page via a content_script. Please reach out if you need more context @lobogang

FantasticoFox commented 2 years ago

image

Content Wallet-Addresses in the external verifier should also be resolved.

rht commented 2 years ago

Fixed in https://github.com/inblockio/aqua-verifier-webextension/commit/276bfffebdb8d1337a3bf44ffc9584de33fd37ba, https://github.com/inblockio/aqua-verifier-webextension/commit/2918201fb7837c9bebb43ccdf510dc6e02b3053a, https://github.com/inblockio/aqua-verifier-webextension/commit/17b28b493ba17ef46b9e444331e732fcd42323e7, https://github.com/inblockio/aqua-verifier-webextension/commit/1524a31580a3da8623cb0e0e5fa0630463fb45ad.

lobogang commented 2 years ago

thanks for that fix @rht , I'll merge new main into my PR (https://github.com/inblockio/aqua-verifier-webextension/pull/62) before going forward with offline_verification updates