inbo / camtraptor

Camtraptor is an R package to read, explore and visualize Camera Trap Data Packages (Camtrap DP)
https://inbo.github.io/camtraptor/
MIT License
10 stars 2 forks source link

Extend functionality of `get_cam_op`: allow `sessionCol` argument to add `sessionID` in `stationName` column as in camtrapR #288

Closed MartijnUH closed 1 year ago

MartijnUH commented 1 year ago

Naming convention in camtrapR: stationID__SESS_sessionID _expample: Station1__SESS2019

See https://jniedballa.github.io/camtrapR/reference/cameraOperation.html

damianooldoni commented 1 year ago

Thanks @MartijnUH.

Some extra words for my maintainer mates, @peterdesmet and @PietrH.

This issue/feature request came up during the meeting hold with @MartijnUH and @jimcasaer on Monday, Nov 11, in the framework of my support of their modelling research.

The label "urgent" means that this feature will be implemented as version 0.20.x. We all know that it's better to change things after the release of camtraptor v1.0 which is also something urgent, especially now that camtrapdp v1 has been officially released.

However, this feature is:

PietrH commented 1 year ago

Let me know if you need any help or input Damiano.

damianooldoni commented 1 year ago

Thanks @PietrH. I will need your help as reviewer. I am planning to work on this this afternoon and tomorrow. I will also ask @MartijnUH to review as major user.

PietrH commented 1 year ago

I will review all the things! :hamster:

damianooldoni commented 1 year ago

Whiel working on this in #289 I noticed that we could easily add the similar argument camera_col and so to be even more camtrapR compliant. Probably something we do not really need but I think it's better to do it now than having to add it at a later stage.

Convention used in camtrapR implemented: Station__SESS_SessionID__CAM_CameraID

damianooldoni commented 1 year ago

I also check that the words __SESS_ and __CAM_ are not present in station_col, session_col and cam_col. Again, this is to follow the guidelines of camtrapR.