search

inbo / reporting-rshiny-grofwildjacht

Rshiny app for grofwildjacht
https://grofwildjacht.inbo.be/
MIT License
1 stars 1 forks source link

Feature#438 #444

Closed Yingjie-ZhangOA closed 8 months ago

Yingjie-ZhangOA commented 8 months ago

implementation of kencijfer tabel

Yingjie-ZhangOA commented 8 months ago

issue caused by the new pipe operator "|>" is not available in R versions prior to R4.1.0, removed the use of pipe.

Yingjie-ZhangOA commented 8 months ago

I'm able to build the app now.

Just 1 thing that should be fixed before merging, namely the thresholds reset when changing the year. Can these remain set until the user changes them ?

It's something we can do, but what if the retained threshold exceeds the range of the data given currently selected year. Should we extend the range to cover the retained threshold? it feels a bit weird as the range doesn't reflect the actual data.

mvarewyck commented 8 months ago

It's something we can do, but what if the retained threshold exceeds the range of the data given currently selected year. Should we extend the range to cover the retained threshold? it feels a bit weird as the range doesn't reflect the actual data.

If the currently selected threshold exceeds the range I would reset it to the default starting value. Not extend the range.

SanderDevisscher commented 8 months ago

I'm able to build the app now. Just 1 thing that should be fixed before merging, namely the thresholds reset when changing the year. Can these remain set until the user changes them ?

It's something we can do, but what if the retained threshold exceeds the range of the data given currently selected year. Should we extend the range to cover the retained threshold? it feels a bit weird as the range doesn't reflect the actual data.

Hmm, you make a valid point. However I think our users will mainly want to compare the situation 1 one year with another once they have set their preferred threshold. Also I think they'll mainly set "low" thresholds so this won't be that big an issue. However we need to anticipate some users that will exceed the data range threshold. I think therefor it is best to set a disclaimer when the threshold exceeds the data range stating something like: "De gekozen drempelwaarde is ligt hoger dan de beschikbare data voor dit jaar, verlaag de drempelwaarde!"

SanderDevisscher commented 8 months ago

It's something we can do, but what if the retained threshold exceeds the range of the data given currently selected year. Should we extend the range to cover the retained threshold? it feels a bit weird as the range doesn't reflect the actual data.

If the currently selected threshold exceeds the range I would reset it to the default starting value. Not extend the range.

Even better ;-)

Yingjie-ZhangOA commented 8 months ago

It's something we can do, but what if the retained threshold exceeds the range of the data given currently selected year. Should we extend the range to cover the retained threshold? it feels a bit weird as the range doesn't reflect the actual data.

If the currently selected threshold exceeds the range I would reset it to the default starting value. Not extend the range.

Even better ;-)

In case of retained selection exceeds the range, the maximal value is taken as default fc8e843

SanderDevisscher commented 8 months ago

@Yingjie-ZhangOA have all necessary changes been implemented ?

Yingjie-ZhangOA commented 8 months ago

@Yingjie-ZhangOA have all necessary changes been implemented ?

Yes

In case of retained selection exceeds the range, the maximal value is taken as default.

This has been implemented in https://github.com/inbo/reporting-rshiny-grofwildjacht/commit/fc8e843797ef22ae09e023bcd2068f19eb59bd9c