search

inboundnow / retired-landing-pages

Create landing pages for your WordPress site. Monitor and improve conversion rates, run A/B split tests, customize your own templates and more.
http://www.inboundnow.com/landing-pages/
GNU General Public License v2.0
4 stars 2 forks source link

Possible conflict between TGM libraries #299

Open daprela opened 8 years ago

daprela commented 8 years ago

I'f I'm not wrong, Inboundnow uses the TGM library. This support request http://support.inboundnow.com/support/topic/issue-with-parallax-type-theme

reports an issue with a theme that also uses the tgm library, probably some conflict with our implementation.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

atwellpub commented 8 years ago

@jrfnl

The changes below helped solve this conflict.

We are telling TGMPA to load after_theme_setup instead of in plugins_loaded. This tells ours to load last.

We're also moving the function that registers the tgmpa class global into the class itself and telling it not to load tgmpa if the global has already been registered.

All these are extra fail-safes.

daprela commented 8 years ago

The client is reporting that while the two first themes reported don't have any issues anymore, another theme called Oneengine V1.11 is having the same problems even after our fix.

I suspect that this will go on infinitely, someone will always find a theme causing issues.

atwellpub commented 8 years ago

I've removed TGM from landing pages. Soon instead of Plugins recommending each other, we'll encourage people to use the inbound pro plugin.

DavidWells commented 8 years ago

I'd recommend keeping it. Moving it to shared and cross promoting from cta and leads. (or figuring out a new simpler cross promo setup)

The only reason leads has the amount of active installs is directly from tgm to install.

More free users means more potential pro users

On Feb 7, 2016, at 1:53 PM, Hudson Atwell notifications@github.com wrote:

I've removed TGM from landing pages. Soon instead of Plugins recommending each other, we'll encourage people to use the inbound pro plugin.

— Reply to this email directly or view it on GitHub.

atwellpub commented 8 years ago

Agree'd before the next release I'm going to have call to actions pointing users to signup and download the master client to get Leads and Calls to action (same on the other stand alones).