pep8speaks
commented
6 years ago Hello @TomMaullin! Thanks for updating the PR.
- In the file
nidmfsl/fsl_exporter/fsl_exporter.py, following are the PEP8 issues :
Line 1249:80: E501 line too long (88 > 79 characters) Line 1259:80: E501 line too long (249 > 79 characters) Line 1261:80: E501 line too long (143 > 79 characters) Line 1262:31: E231 missing whitespace after ',' Line 1262:74: E231 missing whitespace after ',' Line 1263:31: E231 missing whitespace after ',' Line 1263:80: E501 line too long (123 > 79 characters) Line 1263:116: E231 missing whitespace after ',' Line 1264:31: E231 missing whitespace after ',' Line 1264:76: E231 missing whitespace after ',' Line 1264:80: E501 line too long (83 > 79 characters) Line 1267:80: E501 line too long (114 > 79 characters) Line 1268:80: E501 line too long (145 > 79 characters) Line 1311:37: W291 trailing whitespace Line 1318:20: E714 test for object identity should be 'is not' Line 1321:80: E501 line too long (88 > 79 characters) Line 1333:31: E231 missing whitespace after ',' Line 1333:74: E231 missing whitespace after ',' Line 1336:80: E501 line too long (110 > 79 characters)
TomMaullin
cmaumet
This is a really quick PR. I believe this fix in part will resolve the error thrown in issue #126 . The main problem lies around the try catch statement on lines 67-88 of
fsl_exporter.py.The problem comes from the fact that the
self.cleanup()method on line 87 uses the variableself.export_dir. However, this variable is only assigned during the call to the super class on line 68.As the call to the superclass is in the try block and the call to the cleanup function is in the except block the variable
self.export_dir, I believe this is the cause of the reported error message.Note: This addresses the specific error in the issue but, as I could not replicate the issue, I cannot tell why this except block was being executed in the first place.