preckrasno
commented
1 year ago Left some comments.
Please note that 'zipcode' and 'city' options may be removed for the next major release (4.0.0) but we can bring it in for 3.x.x releases.
Ideally, the app needs to cover 2 use cases:
- Automatic location fetching that updates as the user changes locations, and
- Manual location based on something like city or lat/long.
System location and lat/long input cover both of these cases. Separately, there has been an issue with city Id coming back from the API for the zip code case where "See Full Weather" always shows the weather for the wrong location. This issue is not present for the "city" case though.
Regarding the goal of this PR. I had issues with the default location-based and lat/long options, as they showed weather for the wrong locality. Additionally, I found that openweathermap was not handling my zip code and country combination properly. This led me to believe that adding an option to retrieve weather data by city would be beneficial for the app.
Thank you for your comments and feedback, and I look forward to any further suggestions or changes that may be needed to improve this feature.
Added option to fetch weather via city name and iso 3166 country code