search

indexiatech / re-notif

Redux & React based Notifications center.
http://indexiatech.github.io/re-notif
BSD 3-Clause "New" or "Revised" License
148 stars 45 forks source link

redux-notifications fails to compile with browserify #44

Closed patsplat closed 7 years ago

patsplat commented 7 years ago

Browserify fails when requiring redux-notifications. Provided test project: redux-notifications-browserify.zip

redux-notifications-browserify $ npm install
redux-notifications-browserify $ npm test

> redux-notifications-browserify@1.0.0 test /Users/patrick/Google Drive/redux-notifications-browserify
> node_modules/browserify/bin/cmd.js index.js  -o output.js -t [ babelify --presets [ es2015 react ] ]

redux-notifications-browserify/node_modules/redux-notifications/css/styles.css:1
.notif-transition-enter {
^
ParseError: Unexpected token
npm ERR! Test failed.  See above for more details.
redux-notifications-browserify $
michelre commented 7 years ago

Yes, I was confronted to the same issue!!

Any solution?

patsplat commented 7 years ago

my workaround was to fork Notif and moved the require(css) out of javascript into my sass build

On Tue, Oct 4, 2016 at 4:26 PM Rémi notifications@github.com wrote:

Yes, I was confronted to the same issue!!

Any solution?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/indexiatech/re-notif/issues/44#issuecomment-251502829, or mute the thread https://github.com/notifications/unsubscribe-auth/AAK5wvZoA-AbW61tZFy2_rrqwvnuEzJSks5qwraFgaJpZM4KNJx4 .

michelre commented 7 years ago

Thanks, I'll try that! :)

kylecesmat commented 7 years ago

This is similar to #36. The CSS is very minimal and is probably better suited to be written inline