indiana-university / rivet-react

Rivet React Component Documentation and Style Guide:
https://indiana-university.github.io/rivet-react/
Other
5 stars 5 forks source link

HeaderAvatar component overwrites its className attribute with attr even if empty #452

Closed pcberg closed 2 months ago

pcberg commented 3 months ago

<HeaderAvatar shortName={createShortName(user)} username={username}/> causes it to loose the rvt-flex (and other) attributes. Hence it has the potential to have wrapping problems, such as shown on this example: Screenshot 2024-08-29 at 10 21 33

this is a workaround:

<HeaderAvatar shortName={createShortName(user)} username={username} className="rvt-flex rvt-items-center rvt-m-left-md rvt-p-bottom-md rvt-p-bottom-none-lg-up" />

It seems to overwrite className: https://github.com/indiana-university/rivet-react/blob/124693bb0cad1eabf9c585ff1bdc05965b9153ad/src/components/Header/HeaderAvatar.jsx#L29-L30

pcberg commented 2 months ago

Confirmed fixed, closing