QType 001

[GoogleCodeExporter]

Information about the task can be found here:

https://drive.google.com/file/d/0B0FuyHpDsrcfMlk2Vl9FTFN2Qjg/edit?usp=sharing

Original issue reported on code.google.com by Lince3D@gmail.com on 30 Apr 2014 at 6:33

• Blocking: #552

[GoogleCodeExporter]

Original comment by Lince3D@gmail.com on 30 Apr 2014 at 6:37

• Now blocking: #552

[GoogleCodeExporter]

Original comment by Raul.San...@gmail.com on 11 May 2014 at 7:28

• Changed state: Started

[GoogleCodeExporter]

Original comment by Raul.San...@gmail.com on 11 Jun 2014 at 9:36

• Changed state: ReadyForReview

Attachments:

• 551.patch

[GoogleCodeExporter]

Results of the review:

QType.h / QType.cpp
--------------------

1- Pointers to instances of QType must be constant (hence, their names will 
change, something like TYPE_INSTANCE_U8).

2- It's not necessary to put the names in separated constants.

3- The signature of FindType is wrong: It must no receive any parameter.

4- FindType is a static method. Remember to change how they are called in the 
tests.

5- The original implementation of the template method must use an #error 
statement so it fails at compile time.

QType_Test.cpp
-----------------

6- The title of the tests: FindType cannot "return a name".

7- Follow the naming conventions:
---The prefix q- is for quaternions.
---Use prefix p- for pointers.
---The prefix s- does not exist. Use str- instead.

Original comment by Lince3D@gmail.com on 12 Jun 2014 at 2:36

• Changed state: Started

[GoogleCodeExporter]

Original comment by Raul.San...@gmail.com on 15 Jun 2014 at 10:48

• Changed state: ReadyForReview

Attachments:

• 551.patch

[GoogleCodeExporter]

Results of the review:

1-Please return null_q instead of 0 in the original constructor.

2-Are the using statements in the CPP necessary?

3-Replace "sType" with "strType" in the tests.

Original comment by Lince3D@gmail.com on 19 Jun 2014 at 11:29

• Changed state: Done