rwg0
commented
9 months ago Ah, the client side code also doesn't like a trailing comma in the JSON response after a list of objects. Although the code (https://github.com/indigo-astronomy/indigo/blob/58abd8e8a39f248f25d8a7c0faf8cd0dd4c97dbb/indigo_drivers/agent_alpaca/indigo_agent_alpaca.c#L253-L257) looks like it will only add a comma if there are more devices to come, I suspect that there are some device entries with 'device_type' of NULL, meaning that a comma gets added but no more data is then appended.
The code below works correctly as it only appends a comma before the second and subsequent items, but of course there are lots of ways to solve this problem
bool comma=false;
while (alpaca_device) {
if (alpaca_device->device_type) {
if (comma)
{
buffer[index++]=',';
buffer[index++]=' ';
}
comma = true;
index += snprintf(buffer + index, INDIGO_BUFFER_SIZE - >
alpaca_device = alpaca_device->next;
} else {
alpaca_device = alpaca_device->next;
}
}
rumengb
DanielVanNoord
Hi,
I've been testing out the 'Alpaca Agent' functionality to try to get Indigo devices working in an ASCOM application (on the ASCOM side I am using the ASCOM Library - https://github.com/ASCOMInitiative/ASCOMLibrary). Unfortunately it fails at the device discovery stage because the ASCOM side code is expecting a number for the 'DeviceNumber' field, but instead the Alpaca Agent returns a string with a number in it - ie
Desired result
"DeviceNumber": 3Actual output
"DeviceNumber": "3"This looks pretty simple to fix fortunately - just removing the quotes around the %d for DeviceNumber in this line
https://github.com/indigo-astronomy/indigo/blob/58abd8e8a39f248f25d8a7c0faf8cd0dd4c97dbb/indigo_drivers/agent_alpaca/indigo_agent_alpaca.c#L252
For reference, the API spec for this is
(you can see the swagger for this here : https://ascom-standards.org/api/?urls.primaryName=ASCOM%20Alpaca%20Management%20API)
I will have a go at building a tweaked version just to make sure there aren't any other 'gotchas' past this one.
cheers,
Robin