search

indrora / Atomic

Atomic: an IRC client from the ashes of yaaic
https://indrora.github.io/Atomic/
GNU General Public License v3.0
124 stars 29 forks source link

Version 2.1 new read identity permission #109

Open krayon opened 8 years ago

krayon commented 8 years ago

When installing v2.1 (from F-Droid) 3 new permissions were added. The two regarding the storage are presumably reasonable however the permission "read phone status and identity" surely isn't required.

indrora commented 8 years ago

Huh, F-Droid is being a little more paranoid than I would expect.

Still has the same three permissions as 1.19: Phone state (for network state), Vibration (to disable/enable buzzing notifications) and storage (for the long-forgotten DCC functionality)

krayon commented 8 years ago

This is not reported by F-Droid but the APK installer. I guess it could be something they're doing in the build process but AFAIK they build from a straight repo clone. Admittedly I haven't tried building it myself as yet.

FWIW, last time I came across this sort of thing, it was someone setting their minimum SDK version too low (via an included 3rd party project) which forces a few nasty permissions on (such as "read phone status and identity"). In the end, I built that myself and found the explanation in the lint output.

indrora commented 8 years ago

This is some API getting paranoid. It might be related to a low-API library, I'm not sure.

I don't have a good answer. Closing.

krayon commented 8 years ago

@indrora well, I can't use any later version until this is fixed so if you re-open it, I'll take ownership and track it down. I don't seem to be able to re-open myself.

indrora commented 8 years ago

If you want this reopened, I can reopen it.

I honestly don't know why this is being prompted, and I'm at this point blaming Android -- it seems to simply grant older applications wanton permissions.

indrora commented 8 years ago

To the best of my knowledge, this is entirely because I requested the "get network connections" permission (to see when the network has gone up/down/changed).