search

inducer / pytools

http://pypi.python.org/pypi/pytools
Other
70 stars 25 forks source link

KeyBuilder: support np.bool{,_} for numpy<2 #267

Closed matthiasdiener closed 2 weeks ago

matthiasdiener commented 2 weeks ago

The attached test fails with numpy 1.26.4 without this PR.

alexfikl commented 2 weeks ago

Maybe it's worth adding a CI with some oldest supported numpy?

inducer commented 2 weeks ago

Maybe it's worth adding a CI with some oldest supported numpy?

:shrug: In an ideal world maybe. But given that https://github.com/scipy/oldest-supported-numpy is deprecated, I don't want to maintain tables of which numpy is the oldest-supported, so I think we'll find these issues as they arise, and I think I'm vaguely OK with that.

inducer commented 2 weeks ago

https://pypi.org/project/pytools/2024.1.15/