Closed benmusson closed 3 months ago
Hi @benmusson , thanks for the PR. Can you add a unit test in WriteModuleXmlTest.kt
?
@brianeray rebased/squashed
@benmusson can you take a look at my stab in #56? I'll probably pull in a reviewer from our side too, someone who knows module dev, because I'm a build engineer.
My focus is too narrow. I can do stuff in Gradle and JVM languages but not have the bigger picture in focus.
The logic:
jarName
.jarName
, find all the scopes where it is applied and append them together in a list usingflatMap
.At this point the de-duplication is complete and the original issue is resolved. https://github.com/inductiveautomation/ignition-module-tools/issues/52
I think it would also be a good idea to force a sort order for the jars, so I added it in.
scope
length (jars used in more places are listed first).scope
alphabeticallyjarName
alphabeticallyBefore:
After: