Bump native-tls dependency

inejge / ldap3

A pure-Rust LDAP library using the Tokio stack

Apache License 2.0

220 stars 38 forks source link

Bump native-tls dependency #30

Closed kpcyrd closed 5 years ago

kpcyrd commented 6 years ago

Refactors the tls code to native-tls 0.2 and tokio-tls 0.2.
Some easy dependency bumps
Drop the clippy dependency, rustup component add clippy-preview --toolchain=nightly is the recommended way to run clippy right now

inejge commented 6 years ago

Thanks for the PR! I won't be able to test and merge it before the middle of the next week, but meanwhile, I'm curious about the changed logic for skipping cert validation (if you happen to know the details): does accept_invalid_certs work on all supported platforms? I can't test on Windows and macOS.

kpcyrd commented 6 years ago

The old function danger_connect_async_without_providing_domain_for_certificate_verification_and_server_name_indication was removed, see the changelog over here: https://github.com/sfackler/rust-native-tls/blob/master/CHANGELOG.md#v020

There are now two functions, one is requiring a trusted cert but doesn't verify the certificate at all, which is closer to the code in the old example. This is a regular function in native-tls, I only tested this on linux, but I assume native-tls has been tested on windows and osx. :)

kpcyrd commented 5 years ago

@inejge any updates? This crate doesn't build on archlinux anymore due to it's openssl 0.9 dependency.

inejge commented 5 years ago

Ouch, thanks for reminding me, I'm afraid I've totally neglected this library recently. Please report any further problems with building on Arch or elsewhere

kpcyrd commented 5 years ago

@inejge thanks! would you mind pushing a new release so I can bump my ldap3 dependency?

inejge commented 5 years ago

I've published 0.6.1 with the accumulated changes.