Make tokio-uds optional to exclude it from minimal

inejge / ldap3

A pure-Rust LDAP library using the Tokio stack

Apache License 2.0

220 stars 38 forks source link

Make tokio-uds optional to exclude it from minimal #31

Closed reyk closed 4 years ago

reyk commented 5 years ago

The used version of tokio-uds is not compiling under OpenBSD, the fix in HEAD never made it into a newer release, and I also don't need UDS in my specific use case. The "minimal" feature would be a good solution but the current Cargo.toml configuration of ldap3 does not make tokio-uds optional, in fact it always compiles it no matter of the features configuration.

reyk commented 5 years ago

I force-pushed an update to make uds an optional feature indeed.

inejge commented 5 years ago

Thanks for the PR! But, isn't this going to break default Windows builds? I believe it might, but I can't check right away, and I never got around to setting up CI with Windows support.