inexorabletash / travellermap

The source code to TravellerMap.com
https://travellermap.com
Other
119 stars 53 forks source link

Sector data contains invalid / misspelled / unknown allegiance codes #240

Open pmoule opened 1 year ago

pmoule commented 1 year ago

Sector data contains a lot of invalid / misspelled / unknown allegiance codes. In surveys this leads to a not complete Alleg section in metadata.

Expectation is, that used codes in a sector's world data should be displayed as allegiances in Alleg section in sector data. As far as I can see, this is exactly your implementation.

Types of invalid codes are different. Sometimes these are simply misspelled wrt casing. Others are completely unknown and not defined in related sector xml. In a different case, allegiance code is different from the one in 'allegiance_code.tab' (e.g. Nx and NaXX). In the latter case generally known code should be used.

Examples:

This pull request fixes all the above in most of the existing sector data.

inexorabletash commented 1 year ago

I've been going through and fixing several of these c/o some updated tooling. Ones that will require more research and/or contacting the author to determine intent:

Faraway:

M1105:

M1120:

M1201:

M1248:

pmoule commented 1 year ago

ah, great work! This fixes major parts from the original PR's findings.

pmoule commented 1 year ago

M1201:

M1105:

inexorabletash commented 1 year ago

Ares and Marischal have corrections now.

inexorabletash commented 1 year ago

That last revision updates:

Faraway / Far Home - define Ns M1105 / Fulani - fix Nav to NaXX M1105 / Harea - fix NX to Nx, define Ns/Nx