search

infernalstudios / Questlog

Other
2 stars 0 forks source link

Objective type `questlog:quest_complete` non-functional #21

Closed Mweems2 closed 2 weeks ago

Mweems2 commented 1 month ago

Describe the bug:

When using questlog:quest_complete as a trigger, the quest will not appear on the questlog screen even if you complete the quest you are supposed to complete. Upon loading into the world, you will get a toast that you have completed the quest, even though the quest is not on the questlog.

Versions: Minecraft version: 1.20.1 Questlog version: 1.0.0 Forge/Fabric (& Fabric API) version: 47.7.0

Other mods: -questlog -datapack: debug9.zip

Logs:

latest.log debug.log

To Reproduce:

  1. Download the datapack and put it inside of a new world.
  2. Load into the world, you'll notice the toast popping up of the "good job!" quest being completed, even though it shouldn't.
  3. Complete the welcome quest by grabbing any type of log. The "good job" quest will still not appear on the questlog as it is supposed to.

Expected behaviour: The "good job!" quest should appear as uncompleted in the quest log after the "welcome" quest is completed by grabbing a log.

Screenshots: Here's a link to a video demonstration of the issue: https://youtu.be/VbUf4p95jnw

Additional info: I went to the infernal studios discord for this problem initially. There, Nekomaster was kind enough to try and help out, but we both could not figure out what it is. We tried a lot of different things, spacing between the description, making sure every tag was correct and seeing if using /ql [quest ID] trigger set as a reward would work, but unfortunately, nothing did.

SwanX1 commented 3 weeks ago

Issue #32:

Didn't have time to write out a full report on it (someone else already did that). It seems that when quests are assigned with the quest completion trigger, they don't appear in the quest log, and can be completed in the background without any need to do the dependency. A toast does pop up, however there is no way to access the quest gui for the completed quest. This bug makes the questlog quite unusable. Hope this can be fixed.

SwanX1 commented 2 weeks ago

This issue has been fixed in version 1.0.2