Closed LucaScorpion closed 1 year ago
Name | Link |
---|---|
Latest commit | c4618c5fec6ac5248a1b8e6c9319efb28010e123 |
Latest deploy log | https://app.netlify.com/sites/the-infi-way/deploys/64f9afbae632e20008ac6a3e |
Deploy Preview | https://deploy-preview-90--the-infi-way.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
Lighthouse |
1 paths audited Performance: 100 Accessibility: 84 Best Practices: 100 SEO: 92 PWA: - View the detailed breakdown and full score reports |
To edit notification comments on pull requests, go to your Netlify site configuration.
Reviewed all changes, looks good. Checked out the branch locally on Windows (you are on Linux, right?) and tried build
, build:watch
and start
, which all worked just fine. In short: approved!
Checked out the branch locally on Windows (you are on Linux, right?) and tried build, build:watch and start, which all worked just fine.
Awesome, thanks :pray: I am indeed on Linux, so it's perfect to have this tested on Windows as well :)
Closes #72
This PR changes the setup to that all build "input" is contained in the
src
directory, and output is generated intobuild
. Functionally everything should still work the same.I've also added some more documentation to the
TemplateProcessor
in the build script, since I noticed that was a bit sparse, and there wasn't really a good explanation of how it should be used. So I figured that would be good, in case other people need to work on that.I also noticed some newlines got replaced (I'm assuming changing
\r\n
to\n
). From my testing that didn't impact anything (specifically looking at the script and accompanying CSP policy), but would be good if a Windows user could double-check that.