search

infinitered / ProMotion-menu

RubyMotion gem allowing you to easily setup a facebook or Path style hidden slide menu easily with the ProMotion gem.
74 stars 29 forks source link

Refactor/pro motion menu #30

Closed ryanlntn closed 10 years ago

ryanlntn commented 10 years ago

@macfanatic @jamonholmgren @silasjmatson Here's the big refactor. Jamon and I aliased a bunch of methods and added gesture support.

markrickert commented 10 years ago

Nice! What you choose MMDrawerController over the hundreds of other similar components?

ryanlntn commented 10 years ago

@markrickert You'll have to ask @macfanatic or @jamonholmgren . My understanding is that PKRevealController was causing issues and MMDrawerController looked like a better option. I'm thinking we may include support for other components in the future so you can achieve different effects by including different pods while still using the same API.

ryanlntn commented 10 years ago

@macfanatic Any feedback? It looks like we duplicated your efforts with regard to gestures. I think the API we came up with makes it a bit easier to set multiple gestures but I'm open to reconsidering it.

macfanatic commented 10 years ago

@ryanlntn I haven't had a chance to really review yet, but definitely liking the look of things from the minute I browsed through it so far!

macfanatic commented 10 years ago

And you're correct, I only went with a convenient way to configure 1 gesture, figured you could drop down back to the ObjC methods if you needed something more sophisticated. Have to check out your work :)

jamonholmgren commented 10 years ago

:+1:

macfanatic commented 10 years ago

The work you guys did with gestures looks great :+1:

Overall, love this refactor!

macfanatic commented 10 years ago

Sweet!