Closed nanamiwang closed 9 years ago
@nanamiwang Thanks for contributing!
This looks like an edge case to me, so rather than changing how the gem works, I think we'll just document your work-around so any other people that run into this issue will find this solution. However, it's @jamonholmgren's decision to make.
Actually, this is @macfanatic and @ryanlntn's baby now. :)
@kevinvangelder Unfortunately it's not all that uncommon for other gems to turn off dependency detection. That's why ProMotion started specifying the file dependencies in the Rakefile. Given that and the fact that ProMotion already does this, I'm for it. Unless @macfanatic and/or @jamonholmgren have any objections.
:+1: There's no downside to this.
Great! Thanks @nanamiwang !
:ok_hand:
Gemfile
Run rake, then an exception occurred:
The root cause is ProMotion-menu depends on RM auto file dependency detection, but 'motion-yapper' turn off this feature by setting detect_dependencies to false. motion-yapper did this because old version of motion-support is incompatible with auto file dependency detection. Learning from ProMotion, this issue can be avoided by specify all file dependencies in Rakefile. clearsightstudio/ProMotion#555