Pure functions for transforms

[willian]

Hi, first of all: thanks for all the hard work on this library.

This is now an issue, but more a curiosity. Why the callback we add for a response transform can't be a pure function? Instead, it expects mutation to the response object from its arguments so it can be passed to axios internally.

For example, this doesn't work:

api.addResponseTransform(response => {
  const badluck = Math.floor(Math.random() * 10) === 0
  if (badluck) {
    return {
      ...response,
      data: {
        ...response.data,
        doorsOpen: false,
        message: 'I cannot let you do that.'
      }
    }
  }

  return response
})

[skellock]

It boils down to a bad judgement call and then being stuck. I wish I had a better answer. 🤣

I'd be open to deprecating it and moving into 2.0 with a better api entirely. =)

[willian]

@skellock thanks for answering me back. When you say "moving into 2.0..." do you mean a new version of apisauce? If so, do you have a list of things you think the new version should have?

Also, I think changing transforms functions to be pure will break compatibility with 1.x, right?

[skellock]

I guess technically that would be 1.0 eh? Since we're 0.15.x currently. I keep forgetting that.

Yes, that would be a breaking change. I'm ok with that. 0.15.x is stable enough to remain here.

So, now that you've got me thinking about it, here's whats on my wish list:

• remove ramda dependency
• explore/reconcile the transformers/interceptors in axios to see if we can replace ours with theirs
• a nice "retry" mechanism -- useful for things like expired tokens or temporary server failures
• expose the http verbs so we can call directly without first creating a client

[divyanshu-srivastava-vs]

what is the status of this ticket ?