Woah! DataTableScreens now use a proper fetch controller!

infinitered / redpotion

We believe iPhone development should be clean, scalable, and fast with a language that developers not only enjoy, but actively choose. With the advent of Ruby for iPhone development the RubyMotion community has combined and tested the most active and powerful gems into a single package called RedPotion

MIT License

233 stars 40 forks source link

Woah! DataTableScreens now use a proper fetch controller! #86

Closed markrickert closed 9 years ago

markrickert commented 9 years ago

This gives us all sorts of awesome functionality like automatically updating the table when the core data changes.

It's magic!

MAGIC

This supersedes #81

Things to do:

[x] ProMotion: move TableClassMethods to its own file so we can reuse it here.
[x] ProMotion: extract the following methods from PM::TableData: create_table_cell, set_data_cell_defaults, build_cell_identifier

markrickert commented 9 years ago

Tests are not passing because this is a pretty big change to the way the DataTableScreen works... need to rework some of the tests so that they use the FetchedResultsController. Any help here would be appreciated @squidpunch @jamonholmgren

markrickert commented 9 years ago

2015-04-23 21_13_36

squidpunch commented 9 years ago

nice @markrickert. I'm planning on giving this a look later today and see if I can help sort out the tests!

GantMan commented 9 years ago

jamonholmgren commented 9 years ago

Reviewed, left comments. Nice work @markrickert !!

squidpunch commented 9 years ago

@markrickert I think you got all the tests sorted out, at least there are no failures - are you looking to add more coverage?

locally

81 specifications (107 requirements), 0 failures, 0 errors

right now travis is failing because of the rescue pointer error in UIColor - which apparently seems to be a bug in RubyMotion that @GantMan submitted an issue for.

twerth commented 9 years ago

Let me know when this is ready to be merged.

markrickert commented 9 years ago

Will do. Still working on the notifications portion of this.

markrickert commented 9 years ago

So I just implemented searchable for DataTableScreen and it works amazingly! One thing left to do is to make sure that updates to the data set are reflected in realtime when IN the search state. Shouldn't be too difficult. I'd LOVE a code review and perhaps some help writing tests.

squidpunch commented 9 years ago

I'm mostly offline this week, but I'll see if I can get some time to review and help on some tests sometime soon.

jamonholmgren commented 9 years ago

Nice, I'll check it out later this week too.

markrickert commented 9 years ago

FYI - lots of tests written and passing. Code review would be nice... or just merge it.

hdr-well-do-it-live

jamonholmgren commented 9 years ago

I'm good to merge. :+1: :shipit: