search

infinum / kotlin-jsonapix

JsonApiX is an Android, annotation processor library that was made to transform regular Kotlin classes into their JSON API representations, with the ability to serialize or deserialize them to or from strings.
Apache License 2.0
38 stars 9 forks source link

Feature/cleanup #14

Closed gobbletsit closed 2 years ago

gobbletsit commented 2 years ago

https://app.productive.io/1-infinum/tasks/2465657

This PR contains changes made to clean up and sort out codestate as much as possible with main focus being on:

  1. original model - refactor
  2. Refactor Spec Builders
  3. Static checker validation

Cpd is removed due to a massive discrepancy between the usefulness that it should provide (even though a lot of classes have already been refactored to support it).

I suggest to add a custom detekt config as some rules are a bit too much by default.

gobbletsit commented 2 years ago

@stjepanbanek Is there something not working?

stjepanbanek commented 2 years ago

@gobbletsit No it's fine, I was just writing it as a precaution 😅 . Nothing to worry about