Closed cstuder closed 1 year ago
Base: 74.93% // Head: 74.93% // No change to project coverage :thumbsup:
Coverage data is based on head (
4809291
) compared to base (c8b67ba
). Patch coverage: 50.00% of modified lines in pull request are covered.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Please review and merge it, 8.2 is now the default version on many new project !
I'm a first-time-contributor, somebody from the Influx team has to trigger the CircelCI build...
@powersj sorry for directly pinging you. Can you take a look?
My plan is to look at this Monday. I'd like to understand why tests didn't run. Given I know next to nothing about PHP I need to see those tests run before hitting merge.
Thanks!
@powersj What tests are you referring to? The Circle CI automated tests don't run because I'm a first-time-contributor and you have to manually approve them to run.
For the unit tests within this package, have a look at PR #139 first. Those should be properly dockerized now.
What tests are you referring to?
The tests on a PR
The Circle CI automated tests don't run because I'm a first-time-contributor and you have to manually approve them to run.
I have no option to do so, it says "Waiting for status to be reported". It looks like I may have already done the the codecov was reported as a comment.
@cstuder tests on master decided to fail: https://app.circleci.com/pipelines/github/influxdata/influxdb-client-php/1655/workflows/84bc58b0-f461-493c-a14d-66db691eb33f Is this a missing dependency?
What happened, did it fix itself? :-)
Anyway, thanks for the new release, looks good.
Proposed Changes
PHP 8.2 throws deprecation notices on this string interpolation syntax. Does not affect the environment variable syntax in the config settings. No functional changes, backward compatible with PHP 7.
Checklist
make test
completes successfully