influxdata / influxdb-client-php

InfluxDB (v2+) Client Library for PHP
https://influxdata.github.io/influxdb-client-php/
MIT License
150 stars 47 forks source link

refactor: Fixes strings to prevent PHP 8.2 notices #140

Closed cstuder closed 1 year ago

cstuder commented 1 year ago

Proposed Changes

PHP 8.2 throws deprecation notices on this string interpolation syntax. Does not affect the environment variable syntax in the config settings. No functional changes, backward compatible with PHP 7.

Checklist

codecov-commenter commented 1 year ago

Codecov Report

Base: 74.93% // Head: 74.93% // No change to project coverage :thumbsup:

Coverage data is based on head (4809291) compared to base (c8b67ba). Patch coverage: 50.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #140 +/- ## ========================================= Coverage 74.93% 74.93% Complexity 424 424 ========================================= Files 25 25 Lines 1093 1093 ========================================= Hits 819 819 Misses 274 274 ``` | [Impacted Files](https://codecov.io/gh/influxdata/influxdb-client-php/pull/140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=influxdata) | Coverage Δ | | |---|---|---| | [src/InfluxDB2/InvokableScriptsApi.php](https://codecov.io/gh/influxdata/influxdb-client-php/pull/140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=influxdata#diff-c3JjL0luZmx1eERCMi9JbnZva2FibGVTY3JpcHRzQXBpLnBocA==) | `13.33% <0.00%> (ø)` | | | [src/InfluxDB2/DefaultApi.php](https://codecov.io/gh/influxdata/influxdb-client-php/pull/140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=influxdata#diff-c3JjL0luZmx1eERCMi9EZWZhdWx0QXBpLnBocA==) | `90.47% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=influxdata). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=influxdata)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dynamicnet commented 1 year ago

Please review and merge it, 8.2 is now the default version on many new project !

cstuder commented 1 year ago

I'm a first-time-contributor, somebody from the Influx team has to trigger the CircelCI build...

ss89 commented 1 year ago

@powersj sorry for directly pinging you. Can you take a look?

powersj commented 1 year ago

My plan is to look at this Monday. I'd like to understand why tests didn't run. Given I know next to nothing about PHP I need to see those tests run before hitting merge.

Thanks!

cstuder commented 1 year ago

@powersj What tests are you referring to? The Circle CI automated tests don't run because I'm a first-time-contributor and you have to manually approve them to run.

For the unit tests within this package, have a look at PR #139 first. Those should be properly dockerized now.

powersj commented 1 year ago

What tests are you referring to?

The tests on a PR

The Circle CI automated tests don't run because I'm a first-time-contributor and you have to manually approve them to run.

I have no option to do so, it says "Waiting for status to be reported". It looks like I may have already done the the codecov was reported as a comment.

powersj commented 1 year ago

@cstuder tests on master decided to fail: https://app.circleci.com/pipelines/github/influxdata/influxdb-client-php/1655/workflows/84bc58b0-f461-493c-a14d-66db691eb33f Is this a missing dependency?

cstuder commented 1 year ago

What happened, did it fix itself? :-)

Anyway, thanks for the new release, looks good.