Handle https requests - Githubissues

influxdata / influxdb-relay

Service to replicate InfluxDB data for high availability

MIT License

855 stars 350 forks source link

Closed alxdm closed 8 years ago

alxdm commented 8 years ago

Hi.

I prepared pull-request with support of HTTPS handling. Could you check it and merge with master branch, please?

gunnaraasen commented 8 years ago

👍 @alexdemidov Can you please sign the CLA?

alxdm commented 8 years ago

@gunnaraasen I have signed CLA.

joelegasse commented 8 years ago

Some changes I'd like to see:

Remove the enabled option, if there is a certificate file set, it will use TLS, if not, plain HTTP over TCP will be used.
Use tls.NewListener rather than two separate listen calls. It means that the only conditional element is the upgrade to TLS, and not the TCP listen portion.
Change the config variable to tls-combined-pem to indicate that we're requiring a single PEM file with both the key and the certificate chain included.

alxdm commented 8 years ago

@joelegasse Thanks for your comments. I have applied changes. Could you have a look, please?

alxdm commented 8 years ago

@joelegasse I renamed tls-combined-pem config option to ssl-combined-pem.

joelegasse commented 8 years ago

@alexdemidov Much cleaner diff, I like it. :-)

alxdm commented 8 years ago

Thanks.