search

informatics-isi-edu / openseadragon-viewer

2D viewer with openseadragon
Apache License 2.0
5 stars 2 forks source link

Solved issue #22 #29

Closed rastogi-bhavya closed 4 years ago

rastogi-bhavya commented 4 years ago

Solved the problems that were mentioned in the issue.

Added code for merging parent node attributes like 'color', 'height' etc, which can also be part of the style attribute, to the child node for displaying the annotation. The attributes which need to be passed down to the child need to be discussed.

As discussed, when a svg file does not have a viewbox attribute, a console.log error is displayed. This error can be handled at a later stage.

RFSH commented 4 years ago

@rastogi-bhavya I think your code looks good. It's just the this.viewBox attribute that we're not sure about. You should be able to figure out the purpose of this attribute later though.

As I mentioned in my previous comment, you still need to add other SVG files for the id vs name logic that you've added. I'll run the regression test after to make sure everything is working.