search

informatikr / hedis

A Redis client library for Haskell.
http://hackage.haskell.org/package/hedis
BSD 3-Clause "New" or "Revised" License
329 stars 127 forks source link

XINFO GROUP and STREAM redis7 compatibility #197

Closed j1r1k closed 1 year ago

j1r1k commented 1 year ago

Make the XINFO GROUP and XINFO STREAM compatible with redis7 without introducing breaking changes. New values are not handled.

Looking at how XInfoStreamResponse handles it with split into XInfoStreamResponse and XInfoStreamEmptyResponse I am not sure it's a sustainable way going forward. I wasn't attempting to handle the new values, since I have no use for them now anyway.

Please let me know if this should be marked as TODO in code or an Issue to keep track of it.

qnikst commented 1 year ago

Hello, firstly let me thank you for you work and excuse us for a long wait.

Recently we have pulled a bit more contained MR for XINFO STREAM and XINFO GROUP support. Please check if upstream version works for you, and if there are missing pieces still I can help to fix them and update hedis version.

qnikst commented 1 year ago

Closing this PR for now, @j1r1k feel free to ping me if upstream version does not work for you