search

ingesolvoll / glimt

HTTP FSM for re-frame
Eclipse Public License 2.0
36 stars 2 forks source link

FSM should be discarded on success/failure #6

Open ingesolvoll opened 2 years ago

ingesolvoll commented 2 years ago

We don't want dead interceptors to keep processing any event when FSM is finished. We could also clear db state, but would have to look into details there. Clearing state too early might harm UX.

mainej commented 2 years ago

Clearing state too early might harm UX.

I agree that this is a big concern. I often want state to stick around (at least for a few seconds) after a request completes, so that I can flash a success (or failure) message or icon.

mainej commented 2 years ago

If you implement this, do you plan to remove restarts? I don't particularly need restarts, just curious.

ingesolvoll commented 2 years ago

Well, with the current implementation it will remove the ability to restart. So maybe something in the config that starts the machine? Like :unmount-when-finished?.

mainej commented 2 years ago

:unmount-when-finished?

👍 sounds reasonable to me.