search

inkle / inky

An editor for ink: inkle's narrative scripting language
http://www.inklestudios.com/ink
2.42k stars 296 forks source link

Use Electron-Builder to Create the Build Artifacts (Installers) #420

Open lunarcloud opened 2 years ago

lunarcloud commented 2 years ago

Much of what #181 was concerned about were installers and signing - all things that using Electron-Builder would enable.

I've started the work in a branch: https://github.com/lunarcloud/inky/tree/electron-builder

But I'm not sure if I have the time right now to fully-test it yet.

lunarcloud commented 2 years ago

To be clear: This seems to work awesomely - at least on Linux, I'm seeing no problems with the 1 commit ( https://github.com/inkle/inky/commit/d5604daaf2d7877b1ddffb59a9304f158028cf8c )

GreenCloversGames commented 2 years ago

Interesting. Will it require an update of Electron, or will it still work on any version of Electron?

lunarcloud commented 2 years ago

Interesting. Will it require an update of Electron, or will it still work on any version of Electron?

No change, left that untouched.

lunarcloud commented 2 years ago

FYI, the only reason this hasn't been pull-requested is because the one non-"binaries in a zip" release, the mac DMG, might not be on-par with what's already built today. And I don't have a mac right now to test/develop with to make that happen.