Convert website to CRA - Githubissues

inland-empire-software-development / landing

Landing page for IESD

MIT License

4 stars 2 forks source link

Convert website to CRA #20

Closed tonynguyen111997 closed 5 years ago

tonynguyen111997 commented 5 years ago

This PR references issue #1

Can someone please check this PR to make sure it's working correctly. If you think the components should be broken down into even smaller components then please push to this branch.

If you're testing this PR, make sure to run yarn install on your local machine to install node_modules

Use yarn start to start the app

Added yarn by using yarn init -y
package.json includes
- bootstrap
- jquery
- node-sass
- popper.js
- react
- react-dom
- react-scripts
- webfontloader

tonynguyen111997 commented 5 years ago

Don't merge this yet. I'm currently working on making it comply with Codacy quality review

tonynguyen111997 commented 5 years ago

Codacy is saying that there are "Unsafe Regular Expression (security/detect-unsafe-regex)", but i'm not sure if we can do anything about that since that's what comes with CRA by default.

lloan commented 5 years ago

@tonynguyen111997 We could add this file to the ignore list. So that it bypasses that file. I wonder if this is a known issue though.