Closed dbarnett closed 2 months ago
LGTM.
+1
On Sat, Sep 28, 2024, at 11:33, David Barnett wrote:
I'm not planning to merge this without explicit :+1: from authors, but wanted to make some kind of tweak to the
--version
output to better reflect the community maintenance of recent gcalcli versions. Not sure the exact convention for including author names in--version
output, but it seemed simplest to just omit author info here instead of trying to reflectauthors: X, Y, Z; maintainers: A, B
.Note authors are still listed in the man page and I'm not worried about changing that (since we already list the bug tracker for reaching maintainers). You can view, comment on, or merge this pull request online at:
https://github.com/insanum/gcalcli/pull/786
-- Commit Summary --
- Simplify --version to omit author names
-- File Changes --
M gcalcli/__init__.py (1) M gcalcli/argparsers.py (2) M gcalcli/cli.py (7)
-- Patch Links --
https://github.com/insanum/gcalcli/pull/786.patch https://github.com/insanum/gcalcli/pull/786.diff
-- Reply to this email directly or view it on GitHub: https://github.com/insanum/gcalcli/pull/786 You are receiving this because your review was requested.
Message ID: @.***>
I'm ok with it. 👍
I'm not planning to merge this without explicit :+1: from authors, but wanted to make some kind of tweak to the
--version
output to better reflect the community maintenance of recent gcalcli versions. Not sure the exact convention for including author names in--version
output, but it seemed simplest to just omit author info here instead of trying to reflectauthors: X, Y, Z; maintainers: A, B
.Note authors are still listed in the man page and I'm not worried about changing that (since we already list the bug tracker for reaching maintainers).