Multiple Dockerfile improvements

insanum / sncli

Simplenote CLI

MIT License

397 stars 35 forks source link

Multiple Dockerfile improvements #115

Closed pataquets closed 3 years ago

pataquets commented 3 years ago

From commit message:

Expose 'editor_packages' build ARG to allow custom building. Update example.
Organize build steps to speed up repeated builds by taking advantage of image layer caching.
Clear 'pipenv' caches and disable 'pip' caching to reduce image size.
Properly set DEBIAN_FRONTEND environment variable on 'apt-get' invocation.

Test it locally by building simply doing:

docker build --build-arg editor_packages="nano" github.com/pataquets/sncli -t sncli:nano

Make sure to set the EDITOR environment variable (using docker run's -e switch) accordingly when launching a container.

pataquets commented 3 years ago

Done, @swalladge. I left python:3.8-buster as base image, but it's working with python:3.8-bullseye which is current Debian stable release. WDYT? I can't voice for the Python version, thou (3.9 is latest).

samuelallan72 commented 3 years ago

Awesome, thanks @pataquets !

I left python:3.8-buster as base image ... WDYT?

Fine by me for now; nothing is too close to EOL yet. :)

pataquets commented 3 years ago

@swalladge While customizing my image, I've found that Debian Buster does not provide the useful bat viewer whereas Bullseye does. Yesterday I dropped the link to bat in the wiki.

I'll send a PR soon, once I have mine working. Last chance to have your say about the Python version :wink:.

samuelallan72 commented 3 years ago

@pataquets

Last chance to have your say about the Python version

Haha sure if you'd like to update the python version, go for it. 3.9 should work fine; I use 3.9 locally for testing sncli already.

N0ury commented 3 years ago

I use 3.9 too. It works fine.